SpotBugs: Fix Method ignores exceptional return value - PrintAsyncTask #15595
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| try { | ||
| Files.createDirectories(Objects.requireNonNull(file.getParentFile()).toPath()); | ||
| } catch (IOException e) { | ||
| Log_OC.e(TAG, "Could not create directory: " + Objects.requireNonNull(file.getParentFile()).getAbsolutePath(), e); |
There was a problem hiding this comment.
If file or file.getParentFile() is null, and we catch it and then throw another one via requireNonNull, it is probably better to
- return in catch block
- do not have those nestet try at all?
alexknop
force-pushed
the
printAsyncDirectory
branch
from
30ad073 to
091750f
Compare
alexknop
force-pushed
the
printAsyncDirectory
branch
from
091750f to
0f1da20
Compare
alexknop
force-pushed
the
printAsyncDirectory
branch
from
0f1da20 to
7b66f31
Compare
alperozturk96
force-pushed
the
printAsyncDirectory
branch
from
7b66f31 to
7c2fed7
Compare
app/src/main/java/com/owncloud/android/ui/asynctasks/PrintAsyncTask.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
alexknop
force-pushed
the
printAsyncDirectory
branch
from
7c2fed7 to
195c398
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15595.apk |
4 participants
There are 16 SpotBugs under
Bad practice:
RV: Bad use of return value from method (16: 0/16/0/0)
Method ignores exceptional return value (16: 0/16/0/0)
Solution:
Leveraging the more modern java.nio.Files library and conducting these make directory, delete, etc. functions via that.
Changing a Submit to an Execute function